refactor: use shared require_treasury/get_fee_bps helpers at all call… - #412
Merged
chonilius merged 1 commit intoSep 27, 2026
Conversation
… sites Replace every inline env.storage().instance().get(&DataKey::Treasury) and .get(&DataKey::FeeBps) read across escrow, milestones, and maintenance-pool with the mergefi_common::require_treasury and mergefi_common::get_fee_bps helpers that already exist for this purpose. The TreasuryKey/FeeBpsKey traits were already implemented for all three contracts' DataKey enums, so the helpers work identically — this resolves the triplication MergeFi#162/MergeFi#163 identified at the call sites themselves.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Enchanterme Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… sites
Replace every inline env.storage().instance().get(&DataKey::Treasury) and .get(&DataKey::FeeBps) read across escrow, milestones, and maintenance-pool with the mergefi_common::require_treasury and mergefi_common::get_fee_bps helpers that already exist for this purpose.
The TreasuryKey/FeeBpsKey traits were already implemented for all three contracts' DataKey enums, so the helpers work identically — this resolves the triplication #162/#163 identified at the call sites themselves.
Summary
Related issues
Closes #325
Closes #326
Closes #241
Closes #338
Changes
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean